Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/multi network #693

Merged
merged 88 commits into from
Feb 7, 2024
Merged

Feat/multi network #693

merged 88 commits into from
Feb 7, 2024

Conversation

dexturr
Copy link
Member

@dexturr dexturr commented Jan 30, 2024

Closes #677
Closes #695

Copy link

github-actions bot commented Jan 30, 2024

Here is your approbation coverage BEFORE this PR:

All ACs: *Criteria*: 278  *Covered*: 271  *by/FeatTest*: -  *by/SysTest*: -  *Uncovered*: 7  *Coverage*: 97.5%

Here is your approbation coverage AFTER this PR:

All ACs: *Criteria*: 296  *Covered*: 286  *by/FeatTest*: -  *by/SysTest*: -  *Uncovered*: 10  *Coverage*: 96.6%

AC Diff Report:

Spec files decreased in % coverage:

1138-EXRP-export_recovery_phrase.md by 13.00%

New spec files and their coverage:

1138-NWST-network_settings.md 100% coverage
1142-NWSW-network_switching.md 75% coverage

WARNING:

You have files with decreased AC coverage. This should not be happening. Please investigate the following files:

1138-EXRP-export_recovery_phrase.md

@JonRay15 JonRay15 linked an issue Jan 31, 2024 that may be closed by this pull request
@dexturr dexturr marked this pull request as ready for review February 5, 2024 15:30
@dexturr dexturr requested review from emilbayes and a team as code owners February 5, 2024 15:30
@dexturr dexturr force-pushed the feat/multi-network branch from 66929ca to d5364ff Compare February 6, 2024 17:15
@daro-maj
Copy link
Contributor

daro-maj commented Feb 7, 2024

link for docs does not work for fairground and mainnet
image

@daro-maj
Copy link
Contributor

daro-maj commented Feb 7, 2024

Why do we have linked nodes if each one returns an error ?

image

@daro-maj
Copy link
Contributor

daro-maj commented Feb 7, 2024

We have error during submit an order and switching the margin mode

image

image

Error: Market with id a79834ef7d9019a60821d4962fc2561663a2558011dc9ed972ab8b01381e8d10 not found at getMarketById (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:109461:20) at VegaMarket (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:111022:21) at renderWithHooks (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:24368:20) at updateFunctionComponent (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:27646:22) at beginWork (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:29659:18) at beginWork$1 (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:35469:16) at performUnitOfWork (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:34603:14) at workLoopSync (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:34509:7) at renderRootSync (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:34477:9) at recoverFromConcurrentError (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:33894:22)

@dexturr
Copy link
Member Author

dexturr commented Feb 7, 2024

We have error during submit an order and switching the margin mode

image ![image](https://private-user-images.githubusercontent.com/119658839/302874336-a5b98538-9b6c-4652-a2e9-bc45d17b08a9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDczMDgzMzgsIm5iZiI6MTcwNzMwODAzOCwicGF0aCI6Ii8xMTk2NTg4MzkvMzAyODc0MzM2LWE1Yjk4NTM4LTliNmMtNDY1Mi1hMmU5LWJjNDVkMTdiMDhhOS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwMjA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDIwN1QxMjEzNThaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05ZGM2M2VmNzkxMjljOTM2MzU5N2M0ZDNmMzQ3MDNmMTc4NzJlNWZkYjViZTRjNjMyMDY0ZmI5NGRjYTE2MGVmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.HE1AtmX6JWF2LHdEUMKXOttJVzetjnHDC4scBz7FUAs)

Error: Market with id a79834ef7d9019a60821d4962fc2561663a2558011dc9ed972ab8b01381e8d10 not found at getMarketById (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:109461:20) at VegaMarket (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:111022:21) at renderWithHooks (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:24368:20) at updateFunctionComponent (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:27646:22) at beginWork (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:29659:18) at beginWork$1 (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:35469:16) at performUnitOfWork (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:34603:14) at workLoopSync (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:34509:7) at renderRootSync (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:34477:9) at recoverFromConcurrentError (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:33894:22)

Is tracked by this ticket: #625

@dexturr
Copy link
Member Author

dexturr commented Feb 7, 2024

Why do we have linked nodes if each one returns an error ?

image

Yes this is correct, these are the nodes so in order to interact with them you'd need to use https://docs.vega.xyz/testnet/api/rest/overview to figure out what end points you want to query etc.

Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

11 New issues
0 Security Hotspots
100.0% Coverage on New Code
1.6% Duplication on New Code

See analysis details on SonarCloud

@dexturr dexturr merged commit dd72dd7 into main Feb 7, 2024
15 checks passed
@dexturr dexturr deleted the feat/multi-network branch February 7, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interim multi-network support Adjust disclaimers on the new wallets
2 participants